[clang] [clang-linker-wrapper] Avoid repeated hash lookups (NFC) (PR #127443)

Nikita Popov via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 17 01:15:15 PST 2025


================
@@ -1060,8 +1060,9 @@ Expected<bool> getSymbolsFromBitcode(MemoryBufferRef Buffer, OffloadKind Kind,
       if (Sym.isFormatSpecific() || !Sym.isGlobal())
         continue;
 
-      bool NewSymbol = Syms.count(Sym.getName()) == 0;
-      auto OldSym = NewSymbol ? Sym_None : Syms[Sym.getName()];
+      auto It = Syms.find(Sym.getName());
+      bool NewSymbol = It == Syms.end();
+      auto OldSym = NewSymbol ? Sym_None : It->second;
----------------
nikic wrote:

Could also reduce this to `Syms.lookup(Sym.getName())`, but maybe that's less explicit...

https://github.com/llvm/llvm-project/pull/127443


More information about the cfe-commits mailing list