[clang-tools-extra] [clang-tidy] Add support for `-ignore-insert-conflict` in `run-clang-tidy.py` (PR #127066)

Carlos Galvez via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 17 00:36:34 PST 2025


Vicente Mataix =?utf-8?q?Ferrándiz?= <vmataix at altair.com>,
Vicente Mataix =?utf-8?q?Ferrándiz?= <vmataix at altair.com>,
Vicente Mataix =?utf-8?q?Ferrándiz?= <vmataix at altair.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/127066 at github.com>


================
@@ -446,6 +448,12 @@ async def main() -> None:
         action="store_true",
         help="Allow empty enabled checks.",
     )
+    parser.add_argument(
+        "-ignore-insert-conflict",
----------------
carlosgalvezp wrote:

This option is currently a no-op as it is, because it doesn't change anything. The default value is True, and this option can only set it to True. If anything, there should be a `-no-ignore-insert-conflict` option that sets it to False, given a default of True.

I still don't fully understand what problem this patch is trying to solve, could you ellaborate? Maybe this patch is not needed at all?

https://github.com/llvm/llvm-project/pull/127066


More information about the cfe-commits mailing list