[clang-tools-extra] [clangd] Enable parsing of forwarding functions in the preamble by default (PR #127359)

Nathan Ridge via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 16 16:05:23 PST 2025


https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/127359

>From fd189ad1b09c59040c3c2c16a7eccc0ce22c5b53 Mon Sep 17 00:00:00 2001
From: Nathan Ridge <zeratul976 at hotmail.com>
Date: Sat, 15 Feb 2025 01:57:10 -0500
Subject: [PATCH] [clangd] Enable parsing of forwarding functions in the
 preamble by default

Fixes https://github.com/clangd/clangd/issues/2324
---
 clang-tools-extra/clangd/ClangdServer.h | 4 ++--
 clang-tools-extra/clangd/Compiler.h     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/clang-tools-extra/clangd/ClangdServer.h b/clang-tools-extra/clangd/ClangdServer.h
index e030bf04122d5..1e612e2ba618e 100644
--- a/clang-tools-extra/clangd/ClangdServer.h
+++ b/clang-tools-extra/clangd/ClangdServer.h
@@ -184,7 +184,7 @@ class ClangdServer {
     bool UseDirtyHeaders = false;
 
     // If true, parse emplace-like functions in the preamble.
-    bool PreambleParseForwardingFunctions = false;
+    bool PreambleParseForwardingFunctions = true;
 
     /// Whether include fixer insertions for Objective-C code should use #import
     /// instead of #include.
@@ -501,7 +501,7 @@ class ClangdServer {
   // Whether the client supports folding only complete lines.
   bool LineFoldingOnly = false;
 
-  bool PreambleParseForwardingFunctions = false;
+  bool PreambleParseForwardingFunctions = true;
 
   bool ImportInsertions = false;
 
diff --git a/clang-tools-extra/clangd/Compiler.h b/clang-tools-extra/clangd/Compiler.h
index 4e68da7610ca2..e513e4c40794a 100644
--- a/clang-tools-extra/clangd/Compiler.h
+++ b/clang-tools-extra/clangd/Compiler.h
@@ -40,7 +40,7 @@ class IgnoreDiagnostics : public DiagnosticConsumer {
 
 // Options to run clang e.g. when parsing AST.
 struct ParseOptions {
-  bool PreambleParseForwardingFunctions = false;
+  bool PreambleParseForwardingFunctions = true;
 
   bool ImportInsertions = false;
 };



More information about the cfe-commits mailing list