[clang] 01b7e65 - [FreeBSD] Fix comparison in f75126eeabba13ce2aab53c2e4296fca12b9da0d

[Alex Richardson via cfe-commits]

Author: Alex Richardson
Date: 2025-02-16T13:45:50-08:00
New Revision: 01b7e65c9197d64531133c5890f076de6c1ae793

URL: https://github.com/llvm/llvm-project/commit/01b7e65c9197d64531133c5890f076de6c1ae793
DIFF: https://github.com/llvm/llvm-project/commit/01b7e65c9197d64531133c5890f076de6c1ae793.diff

LOG: [FreeBSD] Fix comparison in f75126eeabba13ce2aab53c2e4296fca12b9da0d

We have to compare the string contents and not the const char* pointer.
This happened to work in my testing but is not reliable.

Added: 
    

Modified: 
    clang/lib/Driver/ToolChains/FreeBSD.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Driver/ToolChains/FreeBSD.cpp b/clang/lib/Driver/ToolChains/FreeBSD.cpp
index bd6ab0f8aba57..62206c5fb3c59 100644
--- a/clang/lib/Driver/ToolChains/FreeBSD.cpp
+++ b/clang/lib/Driver/ToolChains/FreeBSD.cpp
@@ -456,8 +456,9 @@ void FreeBSD::AddCXXStdlibLibArgs(const ArgList &Args,
   unsigned Major = getTriple().getOSMajorVersion();
   bool SuffixedLib = Args.hasArg(options::OPT_pg) && Major != 0 && Major < 14;
   if (SuffixedLib && GetCXXStdlibType(Args) == CST_Libcxx)
-    llvm::replace(CmdArgs, static_cast<const char *>("-lc++"),
-                  static_cast<const char *>("-lc++_p"));
+    std::replace_if(
+        CmdArgs.begin(), CmdArgs.end(),
+        [](const char *S) { return StringRef(S) == "-lc++"; }, "-lc++_p");
 }
 
 void FreeBSD::AddCudaIncludeArgs(const ArgList &DriverArgs,