[clang-tools-extra] 0bae0bf - [clang-tidy] Avoid repeated hash lookups (NFC) (#127370)
via cfe-commits
cfe-commits at lists.llvm.org
Sun Feb 16 08:14:45 PST 2025
Author: Kazu Hirata
Date: 2025-02-16T08:14:42-08:00
New Revision: 0bae0bf8ba73bd0201c58a6cfd6d9f54aaf39ca2
URL: https://github.com/llvm/llvm-project/commit/0bae0bf8ba73bd0201c58a6cfd6d9f54aaf39ca2
DIFF: https://github.com/llvm/llvm-project/commit/0bae0bf8ba73bd0201c58a6cfd6d9f54aaf39ca2.diff
LOG: [clang-tidy] Avoid repeated hash lookups (NFC) (#127370)
Added:
Modified:
clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp
Removed:
################################################################################
diff --git a/clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp
index 76fa2d916f0e8..509fce3a38471 100644
--- a/clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp
@@ -179,15 +179,15 @@ static bool checkOverrideByDerivedMethod(const CXXMethodDecl *BaseMD,
bool VirtualNearMissCheck::isPossibleToBeOverridden(
const CXXMethodDecl *BaseMD) {
- auto Iter = PossibleMap.find(BaseMD);
- if (Iter != PossibleMap.end())
+ auto [Iter, Inserted] = PossibleMap.try_emplace(BaseMD);
+ if (!Inserted)
return Iter->second;
bool IsPossible = !BaseMD->isImplicit() && !isa<CXXConstructorDecl>(BaseMD) &&
!isa<CXXDestructorDecl>(BaseMD) && BaseMD->isVirtual() &&
!BaseMD->isOverloadedOperator() &&
!isa<CXXConversionDecl>(BaseMD);
- PossibleMap[BaseMD] = IsPossible;
+ Iter->second = IsPossible;
return IsPossible;
}
More information about the cfe-commits
mailing list