[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #127301)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 14 21:35:52 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/127301.diff
1 Files Affected:
- (modified) clang/lib/Sema/SemaDecl.cpp (+3-2)
``````````diff
diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp
index 98c245cdea78f..362df485a025c 100644
--- a/clang/lib/Sema/SemaDecl.cpp
+++ b/clang/lib/Sema/SemaDecl.cpp
@@ -16014,7 +16014,8 @@ static void diagnoseImplicitlyRetainedSelf(Sema &S) {
llvm::DenseMap<const BlockDecl *, bool> EscapeInfo;
auto IsOrNestedInEscapingBlock = [&](const BlockDecl *BD) {
- if (auto It = EscapeInfo.find(BD); It != EscapeInfo.end())
+ auto [It, Inserted] = EscapeInfo.try_emplace(BD);
+ if (!Inserted)
return It->second;
bool R = false;
@@ -16027,7 +16028,7 @@ static void diagnoseImplicitlyRetainedSelf(Sema &S) {
CurBD = CurBD->getParent()->getInnermostBlockDecl();
} while (CurBD);
- return EscapeInfo[BD] = R;
+ return It->second = R;
};
// If the location where 'self' is implicitly retained is inside a escaping
``````````
</details>
https://github.com/llvm/llvm-project/pull/127301
More information about the cfe-commits
mailing list