[clang] d9b55b7 - [CIR] Fix extra `; ` warning, and replace `new` with emplaceBlock (NFC) (#127207)

via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 14 15:29:21 PST 2025


Author: Henrich Lauko
Date: 2025-02-15T00:29:18+01:00
New Revision: d9b55b72103f7d2b35cdc7a6311f217016308d9c

URL: https://github.com/llvm/llvm-project/commit/d9b55b72103f7d2b35cdc7a6311f217016308d9c
DIFF: https://github.com/llvm/llvm-project/commit/d9b55b72103f7d2b35cdc7a6311f217016308d9c.diff

LOG: [CIR] Fix extra `;` warning, and replace `new` with emplaceBlock (NFC) (#127207)

Added: 
    

Modified: 
    clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
index d60a6b38b0c12..74ff89346f3c4 100644
--- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
+++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
@@ -157,9 +157,9 @@ void CIRToLLVMGlobalOpLowering::setupRegionInitializedLLVMGlobalOp(
       op, llvmType, isConst, linkage, symbol, nullptr, alignment, addrSpace,
       isDsoLocal, isThreadLocal,
       /*comdat=*/mlir::SymbolRefAttr(), attributes);
-  newGlobalOp.getRegion().push_back(new mlir::Block());
+  newGlobalOp.getRegion().emplaceBlock();
   rewriter.setInsertionPointToEnd(newGlobalOp.getInitializerBlock());
-};
+}
 
 mlir::LogicalResult
 CIRToLLVMGlobalOpLowering::matchAndRewriteRegionInitializedGlobal(


        


More information about the cfe-commits mailing list