[clang-tools-extra] [clang-tidy] Add support for `-ignore-insert-conflict` in `run-clang-tidy.py` (PR #127066)

[Carlos Galvez via cfe-commits]

Vicente Mataix =?utf-8?q?Ferrándiz?= <vmataix at altair.com>,
Vicente Mataix =?utf-8?q?Ferrándiz?= <vmataix at altair.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/127066 at github.com>


================
@@ -198,9 +198,11 @@ def find_binary(arg: str, name: str, build_path: str) -> str:
 def apply_fixes(
     args: argparse.Namespace, clang_apply_replacements_binary: str, tmpdir: str
 ) -> None:
-    """Calls clang-apply-fixes on a given directory."""
+    """Calls clang-apply-replacements on a given directory."""
     invocation = [clang_apply_replacements_binary]
-    invocation.append("-ignore-insert-conflict")
----------------
carlosgalvezp wrote:

Actually this patch is now changing the default behavior of the tool, which is to ignore conflicts. Users updating the tool will get the opposite behavior without having done anything differently. How big of a deal is this?

https://github.com/llvm/llvm-project/pull/127066