[clang] [ARM][AArch64] Add missing Neon Types (PR #126945)

via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 12 09:01:39 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff c1163b843b63f775817b84f124cdcf33f25c28f6 e618aba47c0e7244105bf325ab8019a085e1ed99 --extensions c,cpp,h -- clang/test/AST/ast-dump-aarch64-neon-types.c clang/include/clang/Basic/Specifiers.h clang/include/clang/Sema/DeclSpec.h clang/lib/AST/ASTContext.cpp clang/lib/AST/Type.cpp clang/lib/Basic/IdentifierTable.cpp clang/lib/Basic/LangOptions.cpp clang/lib/CodeGen/CodeGenTypes.cpp clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseTentative.cpp clang/lib/Sema/DeclSpec.cpp clang/lib/Sema/SemaTemplateVariadic.cpp clang/lib/Sema/SemaType.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp
index f32ab3c8a7..aeed5a1a36 100644
--- a/clang/lib/AST/ASTContext.cpp
+++ b/clang/lib/AST/ASTContext.cpp
@@ -1440,12 +1440,12 @@ void ASTContext::InitBuiltinTypes(const TargetInfo &Target,
 
   if (Target.hasAArch64SVETypes() ||
       (AuxTarget && AuxTarget->hasAArch64SVETypes())) {
-  #define SVE_VECTOR_TYPE(Name, MangledName, Id, SingletonId) \
-    InitBuiltinType(SingletonId, BuiltinType::Id);
-  #define SVE_PREDICATE_TYPE(Name, MangledName, Id, SingletonId) \
-    InitBuiltinType(SingletonId, BuiltinType::Id);
-  #define SVE_OPAQUE_TYPE(Name, MangledName, Id, SingletonId) \
-    InitBuiltinType(SingletonId, BuiltinType::Id);
+#define SVE_VECTOR_TYPE(Name, MangledName, Id, SingletonId)                    \
+  InitBuiltinType(SingletonId, BuiltinType::Id);
+#define SVE_PREDICATE_TYPE(Name, MangledName, Id, SingletonId)                 \
+  InitBuiltinType(SingletonId, BuiltinType::Id);
+#define SVE_OPAQUE_TYPE(Name, MangledName, Id, SingletonId)                    \
+  InitBuiltinType(SingletonId, BuiltinType::Id);
 #include "clang/Basic/AArch64SVEACLETypes.def"
   }
 
diff --git a/clang/lib/Basic/IdentifierTable.cpp b/clang/lib/Basic/IdentifierTable.cpp
index 15bb3f2289..1bc71cff86 100644
--- a/clang/lib/Basic/IdentifierTable.cpp
+++ b/clang/lib/Basic/IdentifierTable.cpp
@@ -112,7 +112,7 @@ enum TokenKey : unsigned {
   KEYHLSL = 0x8000000,
   KEYFIXEDPOINT = 0x10000000,
   KEYACLE = 0x20000000, // Enable Arm Neon vector type keywords
-  KEYMAX = KEYACLE, // The maximum key
+  KEYMAX = KEYACLE,     // The maximum key
   KEYALLCXX = KEYCXX | KEYCXX11 | KEYCXX20,
   KEYALL = (KEYMAX | (KEYMAX - 1)) & ~KEYNOMS18 & ~KEYNOOPENCL &
            ~KEYNOZOS // KEYNOMS18, KEYNOOPENCL, KEYNOZOS are excluded.
diff --git a/clang/lib/Basic/LangOptions.cpp b/clang/lib/Basic/LangOptions.cpp
index 3ffdaacde1..1eb5170b93 100644
--- a/clang/lib/Basic/LangOptions.cpp
+++ b/clang/lib/Basic/LangOptions.cpp
@@ -207,7 +207,6 @@ void LangOptions::setLangDefaults(LangOptions &Opts, Language Lang,
     Opts.ACLE = true;
   }
 
-
   // OpenCL, C++ and C23 have bool, true, false keywords.
   Opts.Bool = Opts.OpenCL || Opts.CPlusPlus || Opts.C23;
 
diff --git a/clang/lib/Sema/DeclSpec.cpp b/clang/lib/Sema/DeclSpec.cpp
index 43302bae4d..a8ece68fe0 100644
--- a/clang/lib/Sema/DeclSpec.cpp
+++ b/clang/lib/Sema/DeclSpec.cpp
@@ -375,7 +375,7 @@ bool Declarator::isDeclarationOfFunction() const {
 #define GENERIC_IMAGE_TYPE(ImgType, Id) case TST_##ImgType##_t:
 #include "clang/Basic/OpenCLImageTypes.def"
 #define NEON_VECTOR_TYPE(Name, BaseType, ElBits, NumEls, VectorKind)           \
-  case TST_##Name:
+    case TST_##Name:
 #include "clang/Basic/AArch64SVEACLETypes.def"
 #define HLSL_INTANGIBLE_TYPE(Name, Id, SingletonId) case TST_##Name:
 #include "clang/Basic/HLSLIntangibleTypes.def"

``````````

</details>


https://github.com/llvm/llvm-project/pull/126945


More information about the cfe-commits mailing list