[libclc] [libclc] Stop installing CLC headers (PR #126908)

Fraser Cormack via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 12 05:25:54 PST 2025


https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/126908

The libclc headers are an implementation detail and are not intended to be used by others as OpenCL headers. The only artifacts of libclc we want to publish are the LLVM bytecode libraries.

As the headers have been incidentally broken by recent changes, this commit takes the step to stop installing the headers at all. Downstreams can use clang's own OpenCL headers, and/or its -fdeclare-opencl-builtins flag.

Fixes #119967.

>From 980cd8632a5aee61919e40c6942c8ab0c772b164 Mon Sep 17 00:00:00 2001
From: Fraser Cormack <fraser at codeplay.com>
Date: Wed, 12 Feb 2025 13:21:55 +0000
Subject: [PATCH] [libclc] Stop installing CLC headers

The libclc headers are an implementation detail and are not intended to
be used by others as OpenCL headers. The only artifacts of libclc we
want to publish are the LLVM bytecode libraries.

As the headers have been incidentally broken by recent changes, this
commit takes the step to stop installing the headers at all. Downstreams
can use clang's own OpenCL headers, and/or its -fdeclare-opencl-builtins
flag.

Fixes #119967.
---
 libclc/CMakeLists.txt | 1 -
 libclc/libclc.pc.in   | 2 --
 2 files changed, 3 deletions(-)

diff --git a/libclc/CMakeLists.txt b/libclc/CMakeLists.txt
index c88ea9700d100..9a3087b680cb9 100644
--- a/libclc/CMakeLists.txt
+++ b/libclc/CMakeLists.txt
@@ -222,7 +222,6 @@ set( tahiti_aliases pitcairn verde oland hainan bonaire kabini kaveri hawaii
 # pkg-config file
 configure_file( libclc.pc.in libclc.pc @ONLY )
 install( FILES ${CMAKE_CURRENT_BINARY_DIR}/libclc.pc DESTINATION "${CMAKE_INSTALL_DATADIR}/pkgconfig" )
-install( DIRECTORY generic/include/clc DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}" )
 
 if( ENABLE_RUNTIME_SUBNORMAL )
   foreach( file IN ITEMS subnormal_use_default subnormal_disable )
diff --git a/libclc/libclc.pc.in b/libclc/libclc.pc.in
index b6e06c9673501..3a9e58b3ef0cc 100644
--- a/libclc/libclc.pc.in
+++ b/libclc/libclc.pc.in
@@ -1,8 +1,6 @@
-includedir=@CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_INCLUDEDIR@
 libexecdir=@CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_DATADIR@/clc
 
 Name: libclc
 Description: Library requirements of the OpenCL C programming language
 Version: @PROJECT_VERSION@
-Cflags: -I${includedir}
 Libs: -L${libexecdir}



More information about the cfe-commits mailing list