[clang] [Driver][ROCm][ASan] Skip checking ':xnack+' feature for gfx12. (PR #126885)

Joseph Huber via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 12 05:19:32 PST 2025


================
@@ -1112,6 +1112,11 @@ bool AMDGPUToolChain::shouldSkipSanitizeOption(
 
   assert(OptionalGpuArch && "Invalid Target ID");
   (void)OptionalGpuArch;
+
+  // Skip checking 'xnack+' feature availability for gfx12 family.
----------------
jhuber6 wrote:

The fact that target-id's push target  features into the `mcpu` value always made this kind of thing messy. Why do we even need this if `xnack` isn't used on gfx12? Isn't it always on or something.

https://github.com/llvm/llvm-project/pull/126885


More information about the cfe-commits mailing list