[clang] [clang][analyzer] fix false positive of BlockInCriticalSectionChecker (PR #126752)

[Gábor Horváth via cfe-commits]

================
@@ -339,6 +425,36 @@ void BlockInCriticalSectionChecker::reportBlockInCritSection(
                                                     os.str(), ErrNode);
   R->addRange(Call.getSourceRange());
   R->markInteresting(Call.getReturnValue());
+  // for 'read' call, check whether it's file descriptor(first argument) is
+  // created by 'open' API with O_NONBLOCK flag and don't report for this
+  // situation.
+  if (Call.getCalleeIdentifier()->getName() == "read") {
+    do {
+      const auto *arg = Call.getArgExpr(0);
+      if (!arg)
+        break;
+
+      const auto *DRE = dyn_cast<DeclRefExpr>(arg->IgnoreImpCasts());
----------------
Xazax-hun wrote:

Matching the AST is not a good idea. What if the user writes something like `cond ? val1 : val2` as the argument? Any reason to not use `CallEvent::getArgSVal`?

https://github.com/llvm/llvm-project/pull/126752