[clang] Reapply "[Driver][ROCm][OpenMP] Fix default ockl linking for OpenMP."… (PR #126671)

Matt Arsenault via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 11 04:23:05 PST 2025


================
@@ -1014,17 +1014,20 @@ RocmInstallationDetector::getCommonBitcodeLibs(
     bool isOpenMP = false) const {
   llvm::SmallVector<ToolChain::BitCodeLibraryInfo, 12> BCLibs;
 
-  auto GPUSanEnabled = [GPUSan]() { return std::get<bool>(GPUSan); };
+  // GPU Sanitizer currently only supports ASan and is enabled through host
+  // ASan.
+  auto GPUSanEnabled = [GPUSan]() {
+    return std::get<bool>(GPUSan) &&
+           std::get<const SanitizerArgs>(GPUSan).needsAsanRt();
+  };
----------------
arsenm wrote:

Why is this using a lambda and capture for a simple and? I'm also surprised `get<bool>` works instead of `get<0>`. 

https://github.com/llvm/llvm-project/pull/126671


More information about the cfe-commits mailing list