[clang] [Clang][Driver][HIP] Fix test for HIP as it was failing (PR #126585)
Sharjeel Khan via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 10 21:52:52 PST 2025
https://github.com/Sharjeel-Khan updated https://github.com/llvm/llvm-project/pull/126585
>From f8b2aa2393ae9cc5329790a78dc995017968a8a1 Mon Sep 17 00:00:00 2001
From: Sharjeel Khan <sharjeelkhan at google.com>
Date: Mon, 10 Feb 2025 19:30:06 +0000
Subject: [PATCH 1/2] Fix test for HIP as it was failing
This PR #125646 added this test and it was failing in Android's
compiler. I removed the Build config because we do not have it and it
passes now.
---
clang/test/Driver/dep-file-flag-with-multiple-offload-archs.hip | 1 -
1 file changed, 1 deletion(-)
diff --git a/clang/test/Driver/dep-file-flag-with-multiple-offload-archs.hip b/clang/test/Driver/dep-file-flag-with-multiple-offload-archs.hip
index 79a52f0bc898127..cf92af03b84285c 100644
--- a/clang/test/Driver/dep-file-flag-with-multiple-offload-archs.hip
+++ b/clang/test/Driver/dep-file-flag-with-multiple-offload-archs.hip
@@ -1,6 +1,5 @@
// RUN: %clang -### -nogpuinc -nogpulib --offload-arch=gfx1030 --offload-arch=gfx1100 --offload-arch=gfx1101 -MD -MF tmp.d %s 2>&1 | FileCheck %s
-// CHECK: Build config:
// CHECK-NOT: {{.*}}clang{{.*}}"-target-cpu" "gfx1030"{{.*}}"-dependency-file" "tmp.d"
// CHECK: {{.*}}lld{{.*}}"-plugin-opt=mcpu=gfx1030"
// CHECK-NOT: {{.*}}clang{{.*}}"-target-cpu" "gfx1100"{{.*}}"-dependency-file" "tmp.d"
>From 9b246c78d28f96b4e8ed47f799d4b44433a1f5f1 Mon Sep 17 00:00:00 2001
From: Sharjeel Khan <sharjeelkhan at google.com>
Date: Tue, 11 Feb 2025 05:51:34 +0000
Subject: [PATCH 2/2] Add --target=x86_64-linux-gnu to test
---
clang/test/Driver/dep-file-flag-with-multiple-offload-archs.hip | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/test/Driver/dep-file-flag-with-multiple-offload-archs.hip b/clang/test/Driver/dep-file-flag-with-multiple-offload-archs.hip
index cf92af03b84285c..f17e56acfb7f743 100644
--- a/clang/test/Driver/dep-file-flag-with-multiple-offload-archs.hip
+++ b/clang/test/Driver/dep-file-flag-with-multiple-offload-archs.hip
@@ -1,4 +1,4 @@
-// RUN: %clang -### -nogpuinc -nogpulib --offload-arch=gfx1030 --offload-arch=gfx1100 --offload-arch=gfx1101 -MD -MF tmp.d %s 2>&1 | FileCheck %s
+// RUN: %clang -### -nogpuinc -nogpulib --offload-arch=gfx1030 --offload-arch=gfx1100 --offload-arch=gfx1101 --target=x86_64-linux-gnu -MD -MF tmp.d %s 2>&1 | FileCheck %s
// CHECK-NOT: {{.*}}clang{{.*}}"-target-cpu" "gfx1030"{{.*}}"-dependency-file" "tmp.d"
// CHECK: {{.*}}lld{{.*}}"-plugin-opt=mcpu=gfx1030"
More information about the cfe-commits
mailing list