[clang] [Clang] Add __has_target_builtin macro (PR #126324)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 10 09:51:50 PST 2025


================
@@ -1797,55 +1798,62 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) {
                                            diag::err_feature_check_malformed);
         return II && HasExtension(*this, II->getName());
       });
-  } else if (II == Ident__has_builtin) {
----------------
AaronBallman wrote:

> I heard in the past we kind of do fix-as-you-go with clang-format where sometimes stuff like this happens.

Sort of. We fix the lines that are touched, but don't reformat otherwise untouched lines because that makes review harder now and blames harder in the future. A better approach is to apply clang-format to the range of code you care about as an NFC change. That doesn't require review. Then you apply your changes on top of the now-formatted code.

https://github.com/llvm/llvm-project/pull/126324


More information about the cfe-commits mailing list