[clang] [TableGen] Avoid repeated map lookups (NFC) (PR #126381)
via cfe-commits
cfe-commits at lists.llvm.org
Sat Feb 8 09:21:58 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/126381.diff
1 Files Affected:
- (modified) clang/utils/TableGen/ClangOptionDocEmitter.cpp (+10-6)
``````````diff
diff --git a/clang/utils/TableGen/ClangOptionDocEmitter.cpp b/clang/utils/TableGen/ClangOptionDocEmitter.cpp
index e08fb11df31002..b6c1aad90b5cb9 100644
--- a/clang/utils/TableGen/ClangOptionDocEmitter.cpp
+++ b/clang/utils/TableGen/ClangOptionDocEmitter.cpp
@@ -109,13 +109,17 @@ Documentation extractDocumentation(const RecordKeeper &Records,
// Pretend no-X and Xno-Y options are aliases of X and XY.
std::string Name = std::string(R->getValueAsString("Name"));
if (Name.size() >= 4) {
- if (Name.substr(0, 3) == "no-" && OptionsByName[Name.substr(3)]) {
- Aliases[OptionsByName[Name.substr(3)]].push_back(R);
- continue;
+ if (Name.substr(0, 3) == "no-") {
+ if (const Record *Opt = OptionsByName[Name.substr(3)]) {
+ Aliases[Opt].push_back(R);
+ continue;
+ }
}
- if (Name.substr(1, 3) == "no-" && OptionsByName[Name[0] + Name.substr(4)]) {
- Aliases[OptionsByName[Name[0] + Name.substr(4)]].push_back(R);
- continue;
+ if (Name.substr(1, 3) == "no-") {
+ if (const Record *Opt = OptionsByName[Name[0] + Name.substr(4)]) {
+ Aliases[Opt].push_back(R);
+ continue;
+ }
}
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/126381
More information about the cfe-commits
mailing list