https://github.com/ilya-biryukov commented: I am still working on going through the commit very thoroughly. It all looks great, just a few minor comments, and I've also left a few notes to not forget where I stopped https://github.com/llvm/llvm-project/pull/125492