[clang] [clang] Implement __attribute__((format_matches)) (PR #116708)

[Erich Keane via cfe-commits]

=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>,
=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>,
=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>,
=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>,
=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>,
=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>,
=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>,
=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>,
=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/116708 at github.com>


https://github.com/erichkeane commented:

Unfortunately you caught me right before I'm leaving for the WG21 meeting, so I won't have much chance to do a thorough review on this until I come back.

That said, 
There are quite a few places with manual loops that I suspect some work learning the LLVM ADT/STLExtras.h and the STL Algorithms would greatly simplify.

https://github.com/llvm/llvm-project/pull/116708