[clang] [clang][X86] Support __attribute__((model("small"/"large"))) (PR #124834)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 5 06:20:20 PST 2025


================
@@ -3117,11 +3120,20 @@ def PragmaClangTextSection : InheritableAttr {
   let Documentation = [InternalOnly];
 }
 
-def CodeModel : InheritableAttr, TargetSpecificAttr<TargetLoongArch> {
+// The code model attribute only applies to LoongArch and x86-64, but for NVPTX
----------------
AaronBallman wrote:

1) Should we update AttrDocs.td?
2) Why is it reasonable to silently ignore the attribute? (That's generally not something we ever do because it becomes almost impossible to realize that your attribute isn't behaving the way you expect.) Please add that description to the patch summary.

https://github.com/llvm/llvm-project/pull/124834


More information about the cfe-commits mailing list