[clang] [clang] Improve diagnostics for vector builtins (PR #125673)

Farzon Lotfi via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 4 14:07:31 PST 2025


================
@@ -2393,8 +2395,10 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
     if (CheckVectorElementCallArgs(&SemaRef, TheCall))
       return true;
     if (SemaRef.BuiltinElementwiseTernaryMath(
-            TheCall, /*CheckForFloatArgs*/
-            TheCall->getArg(0)->getType()->hasFloatingRepresentation()))
+            TheCall, /*ArgTyRestr*/
+            TheCall->getArg(0)->getType()->hasFloatingRepresentation()
+                ? Sema::EltwiseBuiltinArgTyRestriction::FloatTy
----------------
farzonl wrote:

There are many `BuiltinElementwiseTernaryMath` being used in this file, why only update this one? Is there work you want the HLSL team to pick up?

https://github.com/llvm/llvm-project/pull/125673


More information about the cfe-commits mailing list