[clang] [CIR] Lowering to LLVM for global pointers (PR #125619)

[Erich Keane via cfe-commits]

================
@@ -84,6 +138,19 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite(
   SmallVector<mlir::NamedAttribute> attributes;
 
   if (init.has_value()) {
+    auto setupRegionInitializedLLVMGlobalOp = [&]() {
----------------
erichkeane wrote:

Ah, hrmph.  That is unfortunately a much nicer version as a separate function.  Can we have a FIXME to move this once dataLayout, typeConverter, and init.value get moved? (or whatever else needs to be moved?).  It would be great if we could do that sooner, but I see what you mean.

https://github.com/llvm/llvm-project/pull/125619