[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 31 11:20:47 PST 2025


================
@@ -31,6 +33,24 @@ namespace direct {
 std::unique_ptr<llvm::Module>
 lowerDirectlyFromCIRToLLVMIR(mlir::ModuleOp mlirModule,
                              llvm::LLVMContext &llvmCtx);
+
+class CIRToLLVMGlobalOpLowering
+    : public mlir::OpConversionPattern<cir::GlobalOp> {
+  mlir::DataLayout const &dataLayout;
----------------
erichkeane wrote:

Typically we do `const west`, so `const` is on the left of the type.  You do that everywhere else, except for this one point, where it is `east const` (on the right).

SO I guess I'm asking, why:
`mlir::DataLayout const &` instead of `const mlir::DataLayout &`?  And only for this type (in the parameter list below as well).

https://github.com/llvm/llvm-project/pull/125260


More information about the cfe-commits mailing list