[clang] [Clang] [Tests] Canonicalise CLANG_ENABLE_OBJC_REWRITER properly (PR #125117)

via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 30 13:18:49 PST 2025


https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/125117

Canonicalise this CMake variable properly as suggested in https://github.com/llvm/llvm-project/pull/119269#discussion_r1935034073

>From 381054f5efae6c5c56317e08aeb718b2b5ad02d5 Mon Sep 17 00:00:00 2001
From: Sirraide <aeternalmail at gmail.com>
Date: Thu, 30 Jan 2025 22:17:04 +0100
Subject: [PATCH] [Clang] [Tests] Canonicalise CLANG_ENABLE_OBJC_REWRITER
 properly

---
 clang/test/CMakeLists.txt     | 1 +
 clang/test/lit.site.cfg.py.in | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/clang/test/CMakeLists.txt b/clang/test/CMakeLists.txt
index 9ce8365910d5594..988629cd0894d57 100644
--- a/clang/test/CMakeLists.txt
+++ b/clang/test/CMakeLists.txt
@@ -9,6 +9,7 @@ llvm_canonicalize_cmake_booleans(
   CLANG_PLUGIN_SUPPORT
   CLANG_SPAWN_CC1
   CLANG_ENABLE_CIR
+  CLANG_ENABLE_OBJC_REWRITER
   ENABLE_BACKTRACES
   LLVM_BUILD_EXAMPLES
   LLVM_BYE_LINK_INTO_TOOLS
diff --git a/clang/test/lit.site.cfg.py.in b/clang/test/lit.site.cfg.py.in
index ae8b927624e23f8..0a00697ace11417 100644
--- a/clang/test/lit.site.cfg.py.in
+++ b/clang/test/lit.site.cfg.py.in
@@ -22,7 +22,7 @@ config.host_cxx = "@CMAKE_CXX_COMPILER@"
 config.llvm_use_sanitizer = "@LLVM_USE_SANITIZER@"
 config.have_zlib = @LLVM_ENABLE_ZLIB@
 config.have_zstd = @LLVM_ENABLE_ZSTD@
-config.clang_objc_rewriter = "@CLANG_ENABLE_OBJC_REWRITER@" == "ON"
+config.clang_objc_rewriter = @CLANG_ENABLE_OBJC_REWRITER@
 config.clang_default_pie_on_linux = @CLANG_DEFAULT_PIE_ON_LINUX@
 config.clang_default_cxx_stdlib = "@CLANG_DEFAULT_CXX_STDLIB@"
 config.clang_staticanalyzer = @CLANG_ENABLE_STATIC_ANALYZER@



More information about the cfe-commits mailing list