[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

[Hans Wennborg via cfe-commits]

================
@@ -13374,6 +13374,62 @@ void Sema::checkNonTrivialCUnion(QualType QT, SourceLocation Loc,
         .visit(QT, nullptr, false);
 }
 
+bool Sema::GloballyUniqueObjectMightBeAccidentallyDuplicated(
+    const VarDecl *Dcl) {
+  if (!Dcl || !getLangOpts().CPlusPlus)
----------------
zmodem wrote:

If the null check is not needed, I think it should be dropped. If you look at the surrounding methods, you'll see that they don't have such checks.

https://github.com/llvm/llvm-project/pull/117622