[clang] 2f48ca3 - Revert "Silence MSVC warnings; NFC"

[Aaron Ballman via cfe-commits]

Author: Aaron Ballman
Date: 2025-01-30T12:23:18-05:00
New Revision: 2f48ca3aec4aa81b81d8591773bf29b4c72c623f

URL: https://github.com/llvm/llvm-project/commit/2f48ca3aec4aa81b81d8591773bf29b4c72c623f
DIFF: https://github.com/llvm/llvm-project/commit/2f48ca3aec4aa81b81d8591773bf29b4c72c623f.diff

LOG: Revert "Silence MSVC warnings; NFC"

This reverts commit 44c0719e77b37374c89b7fc1320664ebb404323d.

It broke several -Werror bots because of misuse of override.

Added: 
    

Modified: 
    clang/include/clang/AST/DynamicRecursiveASTVisitor.h
    clang/lib/AST/DynamicRecursiveASTVisitor.cpp

Removed: 
    


################################################################################
diff  --git a/clang/include/clang/AST/DynamicRecursiveASTVisitor.h b/clang/include/clang/AST/DynamicRecursiveASTVisitor.h
index 0efb9ca8ee8c5a..4e0ba568263bf3 100644
--- a/clang/include/clang/AST/DynamicRecursiveASTVisitor.h
+++ b/clang/include/clang/AST/DynamicRecursiveASTVisitor.h
@@ -254,7 +254,6 @@ template <bool IsConst> class DynamicRecursiveASTVisitorBase {
   virtual bool Traverse##CLASS##Decl(MaybeConst<CLASS##Decl> *D);
 #include "clang/AST/DeclNodes.inc"
 
-#define ABSTRACT_DECL(DECL)
 #define DECL(CLASS, BASE)                                                      \
   bool WalkUpFrom##CLASS##Decl(MaybeConst<CLASS##Decl> *D);                    \
   virtual bool Visit##CLASS##Decl(MaybeConst<CLASS##Decl> *D) { return true; }
@@ -276,7 +275,6 @@ template <bool IsConst> class DynamicRecursiveASTVisitorBase {
   virtual bool Traverse##CLASS##Type(MaybeConst<CLASS##Type> *T);
 #include "clang/AST/TypeNodes.inc"
 
-#define ABSTRACT_TYPE(CLASS, BASE)
 #define TYPE(CLASS, BASE)                                                      \
   bool WalkUpFrom##CLASS##Type(MaybeConst<CLASS##Type> *T);                    \
   virtual bool Visit##CLASS##Type(MaybeConst<CLASS##Type> *T) { return true; }

diff  --git a/clang/lib/AST/DynamicRecursiveASTVisitor.cpp b/clang/lib/AST/DynamicRecursiveASTVisitor.cpp
index 75d49f6eca76cf..b478e7a39ea186 100644
--- a/clang/lib/AST/DynamicRecursiveASTVisitor.cpp
+++ b/clang/lib/AST/DynamicRecursiveASTVisitor.cpp
@@ -221,7 +221,7 @@ template <bool Const> struct Impl : RecursiveASTVisitor<Impl<Const>> {
     return Visitor.Traverse##CLASS##Decl(D);                                   \
   }
 #include "clang/AST/DeclNodes.inc"
-#define ABSTRACT_DECL(DECL)
+
 #define DECL(CLASS, BASE)                                                      \
   bool Visit##CLASS##Decl(CLASS##Decl *D) {                                    \
     return Visitor.Visit##CLASS##Decl(D);                                      \
@@ -246,7 +246,6 @@ template <bool Const> struct Impl : RecursiveASTVisitor<Impl<Const>> {
   }
 #include "clang/AST/TypeNodes.inc"
 
-#define ABSTRACT_TYPE(CLASS, BASE)
 #define TYPE(CLASS, BASE)                                                      \
   bool Visit##CLASS##Type(CLASS##Type *T) {                                    \
     return Visitor.Visit##CLASS##Type(T);                                      \