[clang] [clang] UEFI ABI fixes for X86_64 (PR #124992)
Roland McGrath via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 29 16:19:03 PST 2025
================
@@ -74,7 +74,7 @@ static CCMangling getCallingConvMangling(const ASTContext &Context,
if (FD->isMain() && FD->getNumParams() == 2)
return CCM_WasmMainArgcArgv;
- if (!Triple.isOSWindows() || !Triple.isX86())
+ if (!Triple.isOSWindowsOrUEFI() || !Triple.isX86())
----------------
frobtech wrote:
As we discussed offline, I'd really rather see all sites like this use a predicate that's specific to what matters to the call site in precise terms. This predicate is really an answer to the question rather than the question that should be asked. It presumes the answer is "Windows or UEFI targets", when the question it should be asking is something more like, "What C++ ABI name mangling regime is in use by this target?"
https://github.com/llvm/llvm-project/pull/124992
More information about the cfe-commits
mailing list