[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

[Michael Flanders via cfe-commits]

================
@@ -119,7 +120,26 @@ class MemRegion : public llvm::FoldingSetNode {
 
   virtual MemRegionManager &getMemRegionManager() const = 0;
 
-  LLVM_ATTRIBUTE_RETURNS_NONNULL const MemSpaceRegion *getMemorySpace() const;
+  /// Deprecated. Gets the 'raw' memory space of a memory region's base region.
+  /// Deprecated in favor of the memory space trait which maps memory regions to
+  /// memory spaces, allowing dynamic updating of a memory region's memory
+  /// space.
+  /// @deprecated Use getMemorySpace(ProgramStateRef) instead.
----------------
Flandini wrote:

Thoughts on this deprecation comment vs deprecation attribute? I think there are probably too many current usages to mark it with an attribute.

https://github.com/llvm/llvm-project/pull/123003