[clang] [Driver][ASan] Refactor Clang-Driver "Sanitizer Bitcode" linking. (PR #123922)

via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 26 21:33:44 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 65df99c208ed40271f6dcdfc29bed56540467ce7 341fa64bf30585dea8193565142d713f11e008eb --extensions cpp,h -- clang/lib/Driver/ToolChains/AMDGPU.cpp clang/lib/Driver/ToolChains/AMDGPU.h clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp clang/lib/Driver/ToolChains/HIPAMD.cpp clang/lib/Driver/ToolChains/ROCm.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Driver/ToolChains/AMDGPU.cpp b/clang/lib/Driver/ToolChains/AMDGPU.cpp
index 0448d1b7e7..4fb77eceda 100644
--- a/clang/lib/Driver/ToolChains/AMDGPU.cpp
+++ b/clang/lib/Driver/ToolChains/AMDGPU.cpp
@@ -987,7 +987,8 @@ void ROCMToolChain::addClangTargetOptions(
 }
 
 bool RocmInstallationDetector::checkCommonBitcodeLibs(
-    StringRef GPUArch, StringRef LibDeviceFile, DeviceLibABIVersion ABIVer) const {
+    StringRef GPUArch, StringRef LibDeviceFile,
+    DeviceLibABIVersion ABIVer) const {
   if (!hasDeviceLibrary()) {
     D.Diag(diag::err_drv_no_rocm_device_lib) << 0;
     return false;
diff --git a/clang/lib/Driver/ToolChains/ROCm.h b/clang/lib/Driver/ToolChains/ROCm.h
index 7965844f37..681c242b06 100644
--- a/clang/lib/Driver/ToolChains/ROCm.h
+++ b/clang/lib/Driver/ToolChains/ROCm.h
@@ -181,9 +181,8 @@ public:
       const std::tuple<bool, const SanitizerArgs> &GPUSan, bool isOpenMP) const;
   /// Check file paths of default bitcode libraries common to AMDGPU based
   /// toolchains. \returns false if there are invalid or missing files.
-  bool
-  checkCommonBitcodeLibs(StringRef GPUArch, StringRef LibDeviceFile,
-                         DeviceLibABIVersion ABIVer) const;
+  bool checkCommonBitcodeLibs(StringRef GPUArch, StringRef LibDeviceFile,
+                              DeviceLibABIVersion ABIVer) const;
 
   /// Check whether we detected a valid HIP runtime.
   bool hasHIPRuntime() const { return HasHIPRuntime; }

``````````

</details>


https://github.com/llvm/llvm-project/pull/123922


More information about the cfe-commits mailing list