[clang] 186d654 - [Index] Migrate away from PointerUnion::dyn_cast (NFC) (#124389)
via cfe-commits
cfe-commits at lists.llvm.org
Sat Jan 25 01:16:03 PST 2025
Author: Kazu Hirata
Date: 2025-01-25T01:16:00-08:00
New Revision: 186d6546d9c5898a0a32f4616558021d9a908786
URL: https://github.com/llvm/llvm-project/commit/186d6546d9c5898a0a32f4616558021d9a908786
DIFF: https://github.com/llvm/llvm-project/commit/186d6546d9c5898a0a32f4616558021d9a908786.diff
LOG: [Index] Migrate away from PointerUnion::dyn_cast (NFC) (#124389)
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
// isa<T>, cast<T> and the llvm::dyn_cast<T>
Literal migration would result in dyn_cast_if_present (see the
definition of PointerUnion::dyn_cast), but this patch uses dyn_cast
because we expect DclInfo.DeclOrMacro to be nonnull.
Added:
Modified:
clang/lib/Index/FileIndexRecord.cpp
Removed:
################################################################################
diff --git a/clang/lib/Index/FileIndexRecord.cpp b/clang/lib/Index/FileIndexRecord.cpp
index 449c33637eb7e8..cf40a596f50943 100644
--- a/clang/lib/Index/FileIndexRecord.cpp
+++ b/clang/lib/Index/FileIndexRecord.cpp
@@ -55,7 +55,7 @@ void FileIndexRecord::removeHeaderGuardMacros() {
void FileIndexRecord::print(llvm::raw_ostream &OS, SourceManager &SM) const {
OS << "DECLS BEGIN ---\n";
for (auto &DclInfo : Decls) {
- if (const auto *D = DclInfo.DeclOrMacro.dyn_cast<const Decl *>()) {
+ if (const auto *D = dyn_cast<const Decl *>(DclInfo.DeclOrMacro)) {
SourceLocation Loc = SM.getFileLoc(D->getLocation());
PresumedLoc PLoc = SM.getPresumedLoc(Loc);
OS << llvm::sys::path::filename(PLoc.getFilename()) << ':'
More information about the cfe-commits
mailing list