[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

[Michael Flanders via cfe-commits]

================
@@ -437,7 +437,7 @@ bool SymbolReaper::isLiveRegion(const MemRegion *MR) {
   // tell if anything still refers to this region. Unlike SymbolicRegions,
   // AllocaRegions don't have associated symbols, though, so we don't actually
   // have a way to track their liveness.
-  return isa<AllocaRegion, CXXThisRegion, MemSpaceRegion, CodeTextRegion>(MR);
+  return isa<AllocaRegion, CXXThisRegion, CodeTextRegion>(MR);
----------------
Flandini wrote:

I wanted to make sure y'all saw this change here.

I removed this check that "if a MemRegion's base region is a MemSpace and not a symbolic region or var region" then it is live; this seemed to not change any test results and would make further changes a bit easier since we won't have to pass state to everything that queries liveness to add the memspace trait.

Thoughts?

https://github.com/llvm/llvm-project/pull/123003