[clang-tools-extra] 6a97897 - [NFC][modules] Create objects on the stack (#124034)

[via cfe-commits]

Author: Vitaly Buka
Date: 2025-01-23T09:47:10-08:00
New Revision: 6a97897d5c159a52975bac19ac22c7913672c549

URL: https://github.com/llvm/llvm-project/commit/6a97897d5c159a52975bac19ac22c7913672c549
DIFF: https://github.com/llvm/llvm-project/commit/6a97897d5c159a52975bac19ac22c7913672c549.diff

LOG: [NFC][modules] Create objects on the stack (#124034)

`ClangTool` change to fix memory leak.
`FixedCompilationDatabase` changed just to makes it simpler.

Added: 
    

Modified: 
    clang-tools-extra/modularize/CoverageChecker.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/modularize/CoverageChecker.cpp b/clang-tools-extra/modularize/CoverageChecker.cpp
index b536ee00497c03..fe6711398ab7dc 100644
--- a/clang-tools-extra/modularize/CoverageChecker.cpp
+++ b/clang-tools-extra/modularize/CoverageChecker.cpp
@@ -278,15 +278,15 @@ CoverageChecker::collectUmbrellaHeaderHeaders(StringRef UmbrellaHeaderName) {
     sys::fs::current_path(PathBuf);
 
   // Create the compilation database.
-  std::unique_ptr<CompilationDatabase> Compilations;
-  Compilations.reset(new FixedCompilationDatabase(Twine(PathBuf), CommandLine));
+  FixedCompilationDatabase Compilations(Twine(PathBuf), CommandLine);
 
   std::vector<std::string> HeaderPath;
   HeaderPath.push_back(std::string(UmbrellaHeaderName));
 
   // Create the tool and run the compilation.
-  ClangTool Tool(*Compilations, HeaderPath);
-  int HadErrors = Tool.run(new CoverageCheckerFrontendActionFactory(*this));
+  ClangTool Tool(Compilations, HeaderPath);
+  CoverageCheckerFrontendActionFactory ActionFactory(*this);
+  int HadErrors = Tool.run(&ActionFactory);
 
   // If we had errors, exit early.
   return !HadErrors;