[clang] [StrTable] Mechanically convert Hexagon builtins to use TableGen (PR #123460)
Chandler Carruth via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 22 23:22:29 PST 2025
chandlerc wrote:
> > I also so comments on the python script, but as I mentioned there, the script is not code I'm suggesting to check in or maintain, merely documenting for completeness. It was never written to be remotely readable or clean, just to produce a verifiably equivalent TableGen file.
>
> Sure - that's fine, I guess I am mostly skimming it for Ikhlas' sake in case she wants to run something similar downstream.
>
> LGTM.
Should I still wait for @iajbar to review before merging? Just wasn't super clear from this comment.
(Either way, thanks for the review, appreciate it!)
https://github.com/llvm/llvm-project/pull/123460
More information about the cfe-commits
mailing list