[clang] [Driver][ASan] Refactor Clang-Driver "Sanitizer Bitcode" linking. (PR #123922)
Matt Arsenault via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 22 03:06:49 PST 2025
================
@@ -70,6 +70,10 @@ def err_drv_no_rocm_device_lib : Error<
"cannot find ROCm device library%select{| for %1| for ABI version %1}0; provide its path via "
"'--rocm-path' or '--rocm-device-lib-path', or pass '-nogpulib' to build "
"without ROCm device library">;
+def err_drv_no_asan_rt_lib
+ : Error<"AMDGPU address sanitizer runtime library (asanrtl) is not found. "
+ "Please install ROCm device library which supports address "
+ "sanitizer">;
----------------
arsenm wrote:
```suggestion
: Error<"address sanitizer runtime library (asanrtl) is not found">;
```
Error messages should start with lowercase, and the suggestion to install anything is strange. Installation of anything is not required. I also don't see why we would have multiple configurations of the libraries, this should just be packaged in 100% of cases with the rest of the libraries
https://github.com/llvm/llvm-project/pull/123922
More information about the cfe-commits
mailing list