[clang-tools-extra] [clang-tidy] Add ClangQueryChecks config option (PR #123734)

via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 21 08:01:35 PST 2025


DeNiCoN wrote:

> Could it be a normal check under misc and pass the query in config instead of create a new pattern?

It could be. But this will only be a single check. Having the ability to define multiple checks allows to have more fine control over them using NOLINT.

If multiple checks is defined in a single ClangTidyCheck then it should have the ability to report diagnostics under different names, but ClangTidyCheck base class allows to report diagnostics only with a single name passed in the constructor https://github.com/llvm/llvm-project/blob/5deb4ef9ab1144542d748f71235b029bed06dd26/clang-tools-extra/clang-tidy/ClangTidyCheck.cpp#L31 so some changes would have to be made in this case

And I think the approach with a single ClangTidyCheck and multiple checks defined will require some changes in config parsing too

https://github.com/llvm/llvm-project/pull/123734


More information about the cfe-commits mailing list