[clang] 3f07af9 - [AST] Migrate away from PointerUnion::dyn_cast (NFC) (#123283)

via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 17 08:46:20 PST 2025


Author: Kazu Hirata
Date: 2025-01-17T08:46:16-08:00
New Revision: 3f07af93dc013621176f5931ebc8dd07d299b277

URL: https://github.com/llvm/llvm-project/commit/3f07af93dc013621176f5931ebc8dd07d299b277
DIFF: https://github.com/llvm/llvm-project/commit/3f07af93dc013621176f5931ebc8dd07d299b277.diff

LOG: [AST] Migrate away from PointerUnion::dyn_cast (NFC) (#123283)

Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:

  // FIXME: Replace the uses of is(), get() and dyn_cast() with
  //        isa<T>, cast<T> and the llvm::dyn_cast<T>

Literal migration would result in dyn_cast_if_present (see the
definition of PointerUnion::dyn_cast), but this patch uses dyn_cast
because we expect Source to be nonnull.

Added: 
    

Modified: 
    clang/lib/AST/ByteCode/EvaluationResult.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/AST/ByteCode/EvaluationResult.cpp b/clang/lib/AST/ByteCode/EvaluationResult.cpp
index 0ce8f15ea9127c..d603e08c7bb4d4 100644
--- a/clang/lib/AST/ByteCode/EvaluationResult.cpp
+++ b/clang/lib/AST/ByteCode/EvaluationResult.cpp
@@ -160,9 +160,9 @@ bool EvaluationResult::checkFullyInitialized(InterpState &S,
     return true;
 
   SourceLocation InitLoc;
-  if (const auto *D = Source.dyn_cast<const Decl *>())
+  if (const auto *D = dyn_cast<const Decl *>(Source))
     InitLoc = cast<VarDecl>(D)->getAnyInitializer()->getExprLoc();
-  else if (const auto *E = Source.dyn_cast<const Expr *>())
+  else if (const auto *E = dyn_cast<const Expr *>(Source))
     InitLoc = E->getExprLoc();
 
   if (const Record *R = Ptr.getRecord())


        


More information about the cfe-commits mailing list