[clang] [NFC] [BoundsSan] use structured bindings (PR #123228)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 16 12:10:20 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-clang
Author: Florian Mayer (fmayer)
<details>
<summary>Changes</summary>
This slightly simplifies the code.
---
Full diff: https://github.com/llvm/llvm-project/pull/123228.diff
1 Files Affected:
- (modified) clang/lib/CodeGen/CGExpr.cpp (+6-9)
``````````diff
diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp
index 6e5a21c8f01e78..9a9a8c7f6eae09 100644
--- a/clang/lib/CodeGen/CGExpr.cpp
+++ b/clang/lib/CodeGen/CGExpr.cpp
@@ -3607,18 +3607,15 @@ void CodeGenFunction::EmitCheck(
llvm::Value *RecoverableCond = nullptr;
llvm::Value *TrapCond = nullptr;
bool NoMerge = false;
- for (int i = 0, n = Checked.size(); i < n; ++i) {
- llvm::Value *Check = Checked[i].first;
+ for (auto &[Check, Ord] : Checked) {
// -fsanitize-trap= overrides -fsanitize-recover=.
- llvm::Value *&Cond =
- CGM.getCodeGenOpts().SanitizeTrap.has(Checked[i].second)
- ? TrapCond
- : CGM.getCodeGenOpts().SanitizeRecover.has(Checked[i].second)
- ? RecoverableCond
- : FatalCond;
+ llvm::Value *&Cond = CGM.getCodeGenOpts().SanitizeTrap.has(Ord) ? TrapCond
+ : CGM.getCodeGenOpts().SanitizeRecover.has(Ord)
+ ? RecoverableCond
+ : FatalCond;
Cond = Cond ? Builder.CreateAnd(Cond, Check) : Check;
- if (!CGM.getCodeGenOpts().SanitizeMergeHandlers.has(Checked[i].second))
+ if (!CGM.getCodeGenOpts().SanitizeMergeHandlers.has(Ord))
NoMerge = true;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/123228
More information about the cfe-commits
mailing list