[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123156)
Kazu Hirata via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 15 20:48:34 PST 2025
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/123156
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
// isa<T>, cast<T> and the llvm::dyn_cast<T>
Literal migration would result in dyn_cast_if_present (see the
definition of PointerUnion::dyn_cast), but this patch uses dyn_cast
because we expect IntegerType to be nonnull.
>From cc4a38cff1c27fc5783bb06cc67d7e3783e53960 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Wed, 15 Jan 2025 08:54:40 -0800
Subject: [PATCH] [AST] Migrate away from PointerUnion::dyn_cast (NFC)
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
// isa<T>, cast<T> and the llvm::dyn_cast<T>
Literal migration would result in dyn_cast_if_present (see the
definition of PointerUnion::dyn_cast), but this patch uses dyn_cast
because we expect IntegerType to be nonnull.
---
clang/include/clang/AST/Decl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/include/clang/AST/Decl.h b/clang/include/clang/AST/Decl.h
index 27a91a2d07210b..186a3e7fca59db 100644
--- a/clang/include/clang/AST/Decl.h
+++ b/clang/include/clang/AST/Decl.h
@@ -4021,7 +4021,7 @@ class EnumDecl : public TagDecl {
QualType getIntegerType() const {
if (!IntegerType)
return QualType();
- if (const Type *T = IntegerType.dyn_cast<const Type*>())
+ if (const Type *T = dyn_cast<const Type *>(IntegerType))
return QualType(T, 0);
return cast<TypeSourceInfo *>(IntegerType)->getType().getUnqualifiedType();
}
More information about the cfe-commits
mailing list