[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

Jason Rice via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 15 11:24:57 PST 2025


================
@@ -237,7 +237,7 @@ bool Decl::isTemplateParameterPack() const {
 }
 
 bool Decl::isParameterPack() const {
-  if (const auto *Var = dyn_cast<VarDecl>(this))
+  if (const auto *Var = dyn_cast<ValueDecl>(this))
----------------
ricejasonf wrote:

They would still both just look for a PackExpansionType. There is no place where a variable can be expanded that a binding cannot so I think it benefits to have this in ValueDecl. See its use in SemaTemplateVariadic.cpp.

https://github.com/llvm/llvm-project/pull/121417


More information about the cfe-commits mailing list