s-perron wrote: The spir-v test failures are unrelated to your change. It is caused by a problem in spirv-val, and it has been fixed.Don't let that stop you from merging. https://github.com/llvm/llvm-project/pull/116858