[clang] e33f456 - Fixed some warn-override tests in SemaCXX (#122680)

via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 15 03:26:40 PST 2025


Author: LoS
Date: 2025-01-15T12:26:36+01:00
New Revision: e33f456ae591559883e89a1f18b2dec21225e90f

URL: https://github.com/llvm/llvm-project/commit/e33f456ae591559883e89a1f18b2dec21225e90f
DIFF: https://github.com/llvm/llvm-project/commit/e33f456ae591559883e89a1f18b2dec21225e90f.diff

LOG: Fixed some warn-override tests in SemaCXX (#122680)

The `.cpp` extension have been added to test files, so that they can be
runned. Besides, the `warn-suggest-override.cpp` tests have been fixed.

---------

Co-authored-by: LoS <aurumpuro at gmail.com>

Added: 
    clang/test/SemaCXX/warn-inconsistent-missing-destructor-override.cpp
    clang/test/SemaCXX/warn-suggest-destructor-override.cpp
    clang/test/SemaCXX/warn-suggest-override.cpp

Modified: 
    

Removed: 
    clang/test/SemaCXX/warn-inconsistent-missing-destructor-override
    clang/test/SemaCXX/warn-suggest-destructor-override
    clang/test/SemaCXX/warn-suggest-override


################################################################################
diff  --git a/clang/test/SemaCXX/warn-inconsistent-missing-destructor-override b/clang/test/SemaCXX/warn-inconsistent-missing-destructor-override.cpp
similarity index 100%
rename from clang/test/SemaCXX/warn-inconsistent-missing-destructor-override
rename to clang/test/SemaCXX/warn-inconsistent-missing-destructor-override.cpp

diff  --git a/clang/test/SemaCXX/warn-suggest-destructor-override b/clang/test/SemaCXX/warn-suggest-destructor-override.cpp
similarity index 100%
rename from clang/test/SemaCXX/warn-suggest-destructor-override
rename to clang/test/SemaCXX/warn-suggest-destructor-override.cpp

diff  --git a/clang/test/SemaCXX/warn-suggest-override b/clang/test/SemaCXX/warn-suggest-override.cpp
similarity index 58%
rename from clang/test/SemaCXX/warn-suggest-override
rename to clang/test/SemaCXX/warn-suggest-override.cpp
index e06c939ff001fc..c4b5149c681a40 100644
--- a/clang/test/SemaCXX/warn-suggest-override
+++ b/clang/test/SemaCXX/warn-suggest-override.cpp
@@ -17,13 +17,13 @@ struct C {
 
 struct D : public C {
   void run();
-  // expected-warning at -1 {{'run()' overrides a member function but is not marked 'override'}}
+  // expected-warning at -1 {{'run' overrides a member function but is not marked 'override'}}
   ~D();
 };
 
 struct E : public C {
   virtual void run();
-  // expected-warning at -1 {{'run()' overrides a member function but is not marked 'override'}}
+  // expected-warning at -1 {{'run' overrides a member function but is not marked 'override'}}
   virtual ~E();
 };
 
@@ -32,7 +32,8 @@ struct F : public C {
   ~F() override;
 };
 
-struct G : public C {
+struct G : public C { // expected-note {{mark 'G' as 'final'}}
   void run() final;
   ~G() final;
+  // expected-warning at -1 {{class with destructor marked 'final' cannot be inherited from}}
 };


        


More information about the cfe-commits mailing list