[clang] [Hexagon] Add default clang symlinks to CLANG_LINKS_TO_CREATE (PR #123011)

Brian Cain via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 14 21:14:35 PST 2025


https://github.com/androm3da created https://github.com/llvm/llvm-project/pull/123011

Since this cache value overrides the defaults, we end up with `clang` linked to `clang-20`, and some `${triple}-clang*` links, but we're missing `clang++`.  This makes for a toolchain with inconsistent behavior when used in someone's `$PATH`.

We'll add the default symlinks to our list so that C and C++ programs are both built as expected when `clang` and `clang++` are invoked.

>From 9719efa578485a3108e8e3762c62e5e476f97a44 Mon Sep 17 00:00:00 2001
From: Brian Cain <brian.cain at oss.qualcomm.com>
Date: Tue, 14 Jan 2025 21:10:34 -0800
Subject: [PATCH] [Hexagon] Add default clang symlinks to CLANG_LINKS_TO_CREATE

Since this cache value overrides the defaults, we end up with
`clang` linked to `clang-20`, and some `${triple}-clang*` links,
but we're missing `clang++`.  This makes for a toolchain with
inconsistent behavior when used in someone's `$PATH`.

We'll add the default symlinks to our list so that C and C++ programs are both
built as expected when `clang` and `clang++` are invoked.
---
 .../cmake/caches/hexagon-unknown-linux-musl-clang-cross.cmake  | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/clang/cmake/caches/hexagon-unknown-linux-musl-clang-cross.cmake b/clang/cmake/caches/hexagon-unknown-linux-musl-clang-cross.cmake
index 91bbe26b621054..fd2aeec819fc01 100644
--- a/clang/cmake/caches/hexagon-unknown-linux-musl-clang-cross.cmake
+++ b/clang/cmake/caches/hexagon-unknown-linux-musl-clang-cross.cmake
@@ -10,6 +10,9 @@ set(CLANG_LINKS_TO_CREATE
             hexagon-none-elf-clang
             hexagon-unknown-none-elf-clang++
             hexagon-unknown-none-elf-clang
+            clang++
+            clang-cl
+            clang-cpp
             CACHE STRING "")
 
 set(LLVM_INSTALL_TOOLCHAIN_ONLY ON CACHE BOOL "")



More information about the cfe-commits mailing list