[clang-tools-extra] [clang-tidy] Add a release note about unchecked-optional-access smart pointer caching (PR #122290)

Jan Voung via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 14 11:00:31 PST 2025


================
@@ -232,6 +232,10 @@ Changes in existing checks
   <clang-tidy/checks/bugprone/unchecked-optional-access>` to support
   `bsl::optional` and `bdlb::NullableValue` from
   <https://github.com/bloomberg/bde>_.
+  Fixed false positives from smart pointer accessors repeated in checking
+  ``has_value`` and accessing ``value``, by caching the locations returned
+  by the accessors. The option `IgnoreSmartPointerDereference` should no
+  longer be needed.
----------------
jvoung wrote:

I think it can be removed. By "maybe could be removed", did you mean to actually remove the option (together with this change or as a separate change), or to clarify in the release note that it could be removed in the future/soon?

I wasn't sure if it was okay to remove a flag before advertising that it isn't needed.  (though It looks like right now clang-tidy just ignores options that aren't available, instead of failing with an error)?

https://github.com/llvm/llvm-project/pull/122290


More information about the cfe-commits mailing list