[clang-tools-extra] [clang-tidy] Fix modernize-use-integer-sign-comparison comparison (PR #121506)

via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 14 07:26:02 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 4075ddad7183e6f0b66e2c8cc7a03b461a8038e6 61aefcf31a6a114570b95ec4eb9368d2d3a7f7a9 --extensions cpp,h -- clang-tools-extra/clang-tidy/modernize/UseIntegerSignComparisonCheck.cpp clang-tools-extra/clang-tidy/modernize/UseIntegerSignComparisonCheck.h clang-tools-extra/test/clang-tidy/checkers/modernize/use-integer-sign-comparison.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang-tools-extra/clang-tidy/modernize/UseIntegerSignComparisonCheck.cpp b/clang-tools-extra/clang-tidy/modernize/UseIntegerSignComparisonCheck.cpp
index 1905ed72ac..eb3a33e69d 100644
--- a/clang-tools-extra/clang-tidy/modernize/UseIntegerSignComparisonCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/UseIntegerSignComparisonCheck.cpp
@@ -141,11 +141,10 @@ void UseIntegerSignComparisonCheck::check(
   if (LHS == nullptr || RHS == nullptr)
     return;
 
-  if (ConsiderIntSize &&
-      (Result.Context->getTypeSize(
-           SignedCastExpression->getSubExpr()->getType()) >
-       Result.Context->getTypeSize(
-           UnSignedCastExpression->getSubExpr()->getType())))
+  if (ConsiderIntSize && (Result.Context->getTypeSize(
+                              SignedCastExpression->getSubExpr()->getType()) >
+                          Result.Context->getTypeSize(
+                              UnSignedCastExpression->getSubExpr()->getType())))
     return;
 
   const Expr *SubExprLHS = nullptr;

``````````

</details>


https://github.com/llvm/llvm-project/pull/121506


More information about the cfe-commits mailing list