[clang] [clang] Refactor attr diagnostics to use %select (PR #122473)

[Ilya Biryukov via cfe-commits]

================
@@ -3708,9 +3709,9 @@ void Parser::ParseDeclarationSpecifiers(
             continue;
 
           if (PA.getKind() == ParsedAttr::AT_LifetimeBound)
-            Diag(PA.getLoc(), diag::err_attribute_wrong_decl_type_str)
----------------
ilya-biryukov wrote:

Yeah, sorry for not being clear.
I am definitely not pushing for doing this refactoring now, it seems like too much work for relatively little benefit.
There are many things which aren't perfect, I fully agree we should leave this one be and move on to other things.

https://github.com/llvm/llvm-project/pull/122473