[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)
Piotr Zegar via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 13 12:00:49 PST 2025
================
@@ -164,6 +164,33 @@ void UseRangesCheck::registerMatchers(MatchFinder *Finder) {
static void removeFunctionArgs(DiagnosticBuilder &Diag, const CallExpr &Call,
ArrayRef<unsigned> Indexes,
const ASTContext &Ctx) {
+ auto GetCommaLoc =
+ [&](SourceLocation BeginLoc,
+ SourceLocation EndLoc) -> std::optional<CharSourceRange> {
+ auto Invalid = false;
+ auto SourceText = Lexer::getSourceText(
+ CharSourceRange::getCharRange({BeginLoc, EndLoc}),
+ Ctx.getSourceManager(), Ctx.getLangOpts(), &Invalid);
+ assert(!Invalid);
+
+ size_t I = 0;
+ while (I < SourceText.size() && SourceText[I] != ',') {
+ I++;
+ }
+
+ if (I < SourceText.size()) {
+ // also remove space after ,
+ size_t J = I + 1;
+ while (J < SourceText.size() && SourceText[J] == ' ') {
+ J++;
+ }
----------------
PiotrZSL wrote:
for space removal i would use ltrim to take tabs into account also
https://github.com/llvm/llvm-project/pull/118568
More information about the cfe-commits
mailing list