[clang] Fixed some warn-override tests in SemaCXX (PR #122680)

via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 13 02:15:44 PST 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: LoS (2LoS)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/122680.diff


3 Files Affected:

- (renamed) clang/test/SemaCXX/warn-inconsistent-missing-destructor-override.cpp () 
- (renamed) clang/test/SemaCXX/warn-suggest-destructor-override.cpp () 
- (renamed) clang/test/SemaCXX/warn-suggest-override.cpp (+4-3) 


``````````diff
diff --git a/clang/test/SemaCXX/warn-inconsistent-missing-destructor-override b/clang/test/SemaCXX/warn-inconsistent-missing-destructor-override.cpp
similarity index 100%
rename from clang/test/SemaCXX/warn-inconsistent-missing-destructor-override
rename to clang/test/SemaCXX/warn-inconsistent-missing-destructor-override.cpp
diff --git a/clang/test/SemaCXX/warn-suggest-destructor-override b/clang/test/SemaCXX/warn-suggest-destructor-override.cpp
similarity index 100%
rename from clang/test/SemaCXX/warn-suggest-destructor-override
rename to clang/test/SemaCXX/warn-suggest-destructor-override.cpp
diff --git a/clang/test/SemaCXX/warn-suggest-override b/clang/test/SemaCXX/warn-suggest-override.cpp
similarity index 58%
rename from clang/test/SemaCXX/warn-suggest-override
rename to clang/test/SemaCXX/warn-suggest-override.cpp
index e06c939ff001fc..436a17d489693c 100644
--- a/clang/test/SemaCXX/warn-suggest-override
+++ b/clang/test/SemaCXX/warn-suggest-override.cpp
@@ -17,13 +17,13 @@ struct C {
 
 struct D : public C {
   void run();
-  // expected-warning at -1 {{'run()' overrides a member function but is not marked 'override'}}
+  // expected-warning at -1 {{'run' overrides a member function but is not marked 'override'}}
   ~D();
 };
 
 struct E : public C {
   virtual void run();
-  // expected-warning at -1 {{'run()' overrides a member function but is not marked 'override'}}
+  // expected-warning at -1 {{'run' overrides a member function but is not marked 'override'}}
   virtual ~E();
 };
 
@@ -32,7 +32,8 @@ struct F : public C {
   ~F() override;
 };
 
-struct G : public C {
+struct G : public C { // expected-note {{mark 'G' as 'final'}}
   void run() final;
   ~G() final;
+  // expected-warning at -1 {{class with destructor marked as 'final' can not be inherited from}}
 };

``````````

</details>


https://github.com/llvm/llvm-project/pull/122680


More information about the cfe-commits mailing list