[clang] Accept `cl`-style output arguments (`/Fo`, `-Fo`) for `--fmodule-output` (PR #121046)
via cfe-commits
cfe-commits at lists.llvm.org
Sun Jan 12 13:48:28 PST 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 4f4e2abb1a5ff1225d32410fd02b732d077aa056 ff22639d751a38e633a5b2e4fe42586d81b36499 --extensions cpp -- clang/lib/Driver/Driver.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp
index 1bab4efc75..a59f7108c0 100644
--- a/clang/lib/Driver/Driver.cpp
+++ b/clang/lib/Driver/Driver.cpp
@@ -6099,10 +6099,12 @@ const char *Driver::GetNamedOutputPath(Compilation &C, const JobAction &JA,
llvm::PrettyStackTraceString CrashInfo("Computing output path");
// Output to a user requested destination?
if (AtTopLevel && !isa<DsymutilJobAction>(JA) && !isa<VerifyJobAction>(JA)) {
- // CL and not building a PCH. Not sure why the GNU-style driver doesn't need this.
- // May need to rethink.
- Arg *FinalOutput = IsCLMode() && !C.getArgs().hasArg(options::OPT__SLASH_Yc)
- ? C.getArgs().getLastArg(options::OPT__SLASH_Fo, options::OPT__SLASH_Fo_COLON)
+ // CL and not building a PCH. Not sure why the GNU-style driver doesn't need
+ // this. May need to rethink.
+ Arg *FinalOutput =
+ IsCLMode() && !C.getArgs().hasArg(options::OPT__SLASH_Yc)
+ ? C.getArgs().getLastArg(options::OPT__SLASH_Fo,
+ options::OPT__SLASH_Fo_COLON)
: C.getArgs().getLastArg(options::OPT_o);
if (FinalOutput != nullptr) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/121046
More information about the cfe-commits
mailing list