[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

Sun Jan 12 06:37:50 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-arm64-windows-msvc` running on `linaro-armv8-windows-msvc-04` while building `clang-tools-extra` at step 5 "ninja check 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/161/builds/4099

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (ninja check 1) failure: stage 1 checked (failure)
******************** TEST 'LLVM :: CodeGen/AMDGPU/llvm.amdgcn.struct.tbuffer.store.d16.ll' FAILED ********************
Exit Code: 3221225539

Command Output (stdout):
--
# RUN: at line 2
c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\llc.exe -mtriple=amdgcn-amd-amdhsa -mcpu=tonga -verify-machineinstrs < C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll | c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\filecheck.exe -check-prefixes=PREGFX10-UNPACKED C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll
# executed command: 'c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\llc.exe' -mtriple=amdgcn-amd-amdhsa -mcpu=tonga -verify-machineinstrs
# executed command: 'c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\filecheck.exe' -check-prefixes=PREGFX10-UNPACKED 'C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll'
# RUN: at line 3
c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\llc.exe -mtriple=amdgcn-amd-amdhsa -mcpu=gfx810 -verify-machineinstrs < C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll | c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\filecheck.exe -check-prefixes=PREGFX10-PACKED C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll
# executed command: 'c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\llc.exe' -mtriple=amdgcn-amd-amdhsa -mcpu=gfx810 -verify-machineinstrs
# executed command: 'c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\filecheck.exe' -check-prefixes=PREGFX10-PACKED 'C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll'
# RUN: at line 4
c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\llc.exe -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 -verify-machineinstrs < C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll | c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\filecheck.exe -check-prefixes=PREGFX10-PACKED C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll
# executed command: 'c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\llc.exe' -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 -verify-machineinstrs
# executed command: 'c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\filecheck.exe' -check-prefixes=PREGFX10-PACKED 'C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll'
# RUN: at line 5
c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\llc.exe -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1010 -verify-machineinstrs < C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll | c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\filecheck.exe -check-prefixes=GFX10-PACKED C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll
# executed command: 'c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\llc.exe' -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1010 -verify-machineinstrs
# executed command: 'c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\filecheck.exe' -check-prefixes=GFX10-PACKED 'C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll'
# RUN: at line 6
c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\llc.exe -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1100 -amdgpu-enable-vopd=0 -verify-machineinstrs < C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll | c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\filecheck.exe -check-prefixes=GFX11-PACKED C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll
# executed command: 'c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\llc.exe' -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1100 -amdgpu-enable-vopd=0 -verify-machineinstrs
# executed command: 'c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\filecheck.exe' -check-prefixes=GFX11-PACKED 'C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll'
# RUN: at line 7
c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\llc.exe -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1200 -amdgpu-enable-vopd=0 -verify-machineinstrs < C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll | c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\filecheck.exe -check-prefixes=GFX12-PACKED,GFX12-PACKED-SDAG C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll
# executed command: 'c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\llc.exe' -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1200 -amdgpu-enable-vopd=0 -verify-machineinstrs
# executed command: 'c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\filecheck.exe' -check-prefixes=GFX12-PACKED,GFX12-PACKED-SDAG 'C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll'
# RUN: at line 8
c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\llc.exe -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1200 -amdgpu-enable-vopd=0 -verify-machineinstrs < C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll | c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\filecheck.exe -check-prefixes=GFX12-PACKED,GFX12-PACKED-SDAG C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\llvm\test\CodeGen\AMDGPU\llvm.amdgcn.struct.tbuffer.store.d16.ll
# executed command: 'c:\users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\bin\llc.exe' -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1200 -amdgpu-enable-vopd=0 -verify-machineinstrs
# .---command stdout------------
# | 	.amdgcn_target "amdgcn-amd-amdhsa--gfx1200"
# | 	.amdhsa_code_object_version 5
# | 	.text
# | 	.globl	tbuffer_store_d16_x             ; -- Begin function tbuffer_store_d16_x
# | 	.p2align	8
# | 	.type	tbuffer_store_d16_x, at function
# | tbuffer_store_d16_x:                    ; @tbuffer_store_d16_x
# | ; %bb.0:                                ; %main_body
# | 	s_clause 0x1
# | 	s_load_b64 s[6:7], s[4:5], 0x10
# | 	s_load_b128 s[0:3], s[4:5], 0x0
# | 	s_wait_kmcnt 0x0
# | 	v_mov_b32_e32 v0, s6
# | 	v_mov_b32_e32 v1, s7
# | 	tbuffer_store_d16_format_x v0, v1, s[0:3], null format:[BUF_FMT_10_10_10_2_SNORM] idxen
# | 	s_endpgm
# | 	.section	.rodata,"a", at progbits
...

```

</details>

https://github.com/llvm/llvm-project/pull/102299