[clang] [Clang][NFC] Fix a test failure with mold linker (PR #122587)

via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 11 01:51:46 PST 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Younan Zhang (zyn0217)

<details>
<summary>Changes</summary>

Mold prefers the suffix '$' for symbols like PLT and GOT entries, so exclude these symbols as well. Otherwise, this test will fail for developers using mold-linked Clang.

Closes https://github.com/llvm/llvm-project/issues/76982


---
Full diff: https://github.com/llvm/llvm-project/pull/122587.diff


1 Files Affected:

- (modified) clang/test/LibClang/symbols.test (+2-2) 


``````````diff
diff --git a/clang/test/LibClang/symbols.test b/clang/test/LibClang/symbols.test
index fd2ff8bc6cd423..e12b4c9991b811 100644
--- a/clang/test/LibClang/symbols.test
+++ b/clang/test/LibClang/symbols.test
@@ -1,6 +1,6 @@
 # Check that there are no unversioned clang symbols in libclang.so
 RUN: llvm-nm -Dj --defined-only %libclang | grep -v -e '@@LLVM_[0-9]\+$' | not grep '^clang'
 
-# Check that here are no local clang_ symbols (ignoring symbols with .cold or
+# Check that there are no local clang_ symbols (ignoring symbols with .cold or
 # .localalias suffxies.)
-RUN: llvm-nm %libclang | not grep '[a-z] clang_[^.]\+$'
+RUN: llvm-nm %libclang | not grep '[a-z] clang_[^.$]\+$'

``````````

</details>


https://github.com/llvm/llvm-project/pull/122587


More information about the cfe-commits mailing list