[clang-tools-extra] [clang-tidy] Fix modernize-use-integer-sign-comparison comparison (PR #121506)

Piotr Zegar via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 11 01:09:25 PST 2025


================
@@ -80,16 +80,19 @@ UseIntegerSignComparisonCheck::UseIntegerSignComparisonCheck(
     : ClangTidyCheck(Name, Context),
       IncludeInserter(Options.getLocalOrGlobal("IncludeStyle",
                                                utils::IncludeSorter::IS_LLVM),
-                      areDiagsSelfContained()) {}
+                      areDiagsSelfContained()),
+      ConsideringIntSize(Options.get("ConsideringIntegerSize", true)) {}
----------------
PiotrZSL wrote:

use more straightforward option name, like "CheckIntegerSize" or something similar.
I just dont like how this "Considering" sounds in context of an option, even "Consider" would sound better.

https://github.com/llvm/llvm-project/pull/121506


More information about the cfe-commits mailing list